pidgin: 40184d2a: slplink->swboard will only be null if sl...

markdoliner at pidgin.im markdoliner at pidgin.im
Thu Nov 13 01:30:27 EST 2008


-----------------------------------------------------------------
Revision: 40184d2a42088723915b2e4b0173486600ec19ed
Ancestor: ff568de985dc3486322fddce6ba614ad19c859e6
Author: markdoliner at pidgin.im
Date: 2008-11-13T06:28:03
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/40184d2a42088723915b2e4b0173486600ec19ed

Modified files:
        libpurple/protocols/msn/slplink.c

ChangeLog: 

slplink->swboard will only be null if slplink->session is null.  This
should never happen, so this should be a g_return_if_fail() and
not just a simple if(bad)return;

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/slplink.c	59ce0782d9c5484b2057532adf866c98d07b5268
+++ libpurple/protocols/msn/slplink.c	1079709e5e6d2e5dc35593442f984f05cf3cedc5
@@ -234,8 +234,7 @@ msn_slplink_send_msg(MsnSlpLink *slplink
 			slplink->swboard = msn_session_get_swboard(slplink->session,
 													   slplink->remote_user, MSN_SB_FLAG_FT);
 
-			if (slplink->swboard == NULL)
-				return;
+			g_return_if_fail(slplink->swboard != NULL);
 
 			/* If swboard is destroyed we will be too */
 			slplink->swboard->slplinks = g_list_prepend(slplink->swboard->slplinks, slplink);


More information about the Commits mailing list