pidgin: 35f3279d: pkt can't ever be NULL here. It is only...
rlaager at pidgin.im
rlaager at pidgin.im
Fri Nov 14 02:45:50 EST 2008
-----------------------------------------------------------------
Revision: 35f3279d89e9e708d5798f324fa079357a971739
Ancestor: 01402d2a928ffd0f944725efda9c44c8412a863a
Author: rlaager at pidgin.im
Date: 2008-11-14T06:23:04
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/35f3279d89e9e708d5798f324fa079357a971739
Modified files:
libpurple/protocols/qq/qq_network.c
ChangeLog:
pkt can't ever be NULL here. It is only ever allocated once with g_newa(),
which segfaults on failure.
Fixes CID #395
-------------- next part --------------
============================================================
--- libpurple/protocols/qq/qq_network.c fe598869feaa04ec752adfb630fd4c083d7c5042
+++ libpurple/protocols/qq/qq_network.c a311ad38c51cb9b2c614babcbb2f192c058dd5a7
@@ -461,9 +461,6 @@ static void tcp_pending(gpointer data, g
conn->tcp_rxqueue = NULL;
}
- if (pkt == NULL) {
- continue;
- }
/* packet_process may call disconnect and destory data like conn
* do not call packet_process before jump,
* break if packet_process return FALSE */
More information about the Commits
mailing list