pidgin: 65e95cc9: This preferences isn't used anywhere, an...

markdoliner at pidgin.im markdoliner at pidgin.im
Fri Nov 14 13:40:22 EST 2008


-----------------------------------------------------------------
Revision: 65e95cc9ba102ab5564809a2612356278e2052f0
Ancestor: deca43310925438f0718c57aeca1a89a2f7bcb24
Author: markdoliner at pidgin.im
Date: 2008-11-14T18:38:56
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/65e95cc9ba102ab5564809a2612356278e2052f0

Modified files:
        libpurple/protocols/qq/qq.c

ChangeLog: 

This preferences isn't used anywhere, and when we call get_string_list
here I think we lose the reference to the original list, which is a
memleak

-------------- next part --------------
============================================================
--- libpurple/protocols/qq/qq.c	6ce530ad795b2257a0856070cda18170970a67a5
+++ libpurple/protocols/qq/qq.c	2c02f8f59a3ac6475c424554a9a319d86fe04cff
@@ -1149,8 +1149,7 @@ static void init_plugin(PurplePlugin *pl
 
 	server_list = server_list_build('A');
 
-	purple_prefs_add_string_list("/plugins/prpl/qq/serverlist", server_list);
-	server_list = purple_prefs_get_string_list("/plugins/prpl/qq/serverlist");
+	purple_prefs_remove("/plugins/prpl/qq/serverlist");
 
 	server_kv_list = NULL;
 	kvp = g_new0(PurpleKeyValuePair, 1);


More information about the Commits mailing list