pidgin: e05d46b1: Fix an assertion failure/unlikely crash ..

markdoliner at markdoliner at
Fri Nov 14 16:50:27 EST 2008

Revision: e05d46b1a88dfa81c3cc655bf9ab3e90bb6be828
Ancestor: bb7a932bad7b80c82d2c938a3896c6fd670df7ab
Author: markdoliner at
Date: 2008-11-14T21:46:39
Branch: im.pidgin.pidgin

Modified files:


Fix an assertion failure/unlikely crash when:
1. Open a purple_notify_formatted() dialog, such as the QQ about window
   or the AIM "who am I waiting on authorization from?" dialog
2. Close the dialog with the close button
3. Sign off the account

The problem is that the dialog was closed, but it was not removed from
the list of open dialogs.  So purple_notify_close_with_handle() tried
to close it again.

-------------- next part --------------
--- pidgin/gtknotify.c	b7f86e1964c4d426d9aeb715d4880a2effc232f0
+++ pidgin/gtknotify.c	bcea1126b9f82f78d2c5dd70ff0f1f3b5547b267
@@ -703,7 +703,7 @@ pidgin_notify_formatted(const char *titl
 	g_signal_connect_swapped(G_OBJECT(button), "clicked",
-							 G_CALLBACK(gtk_widget_destroy), window);
+							 G_CALLBACK(formatted_close_cb), window);
 	g_signal_connect(G_OBJECT(window), "key_press_event",
 					 G_CALLBACK(formatted_input_cb), NULL);

More information about the Commits mailing list