pidgin: 58d0133e: It's not possible for wasted to be TRUE ...

markdoliner at pidgin.im markdoliner at pidgin.im
Fri Nov 14 21:55:23 EST 2008


-----------------------------------------------------------------
Revision: 58d0133e75e2712cf100a12d194be308dde1b4db
Ancestor: 8469161e7abc3e8faf292c0ea80ad0b4f44f8460
Author: markdoliner at pidgin.im
Date: 2008-11-15T02:49:49
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/58d0133e75e2712cf100a12d194be308dde1b4db

Modified files:
        libpurple/protocols/msn/servconn.c

ChangeLog: 

It's not possible for wasted to be TRUE here.  Wasted will only be TRUE
if we were processing data in one of the read_cb functions and something
called msn_servconn_destroy().  But if we're just now connecting then
we won't be in read_cb

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/servconn.c	64212331bc9b17f3222db67ccbad307657d07149
+++ libpurple/protocols/msn/servconn.c	59f5a37f6d599d753b380898f5fd0a9825506837
@@ -175,14 +175,6 @@ connect_cb(gpointer data, gint source, c
 	servconn = data;
 	servconn->connect_data = NULL;
 
-	if (servconn->wasted)
-	{
-		if (source >= 0)
-			close(source);
-		msn_servconn_destroy(servconn);
-		return;
-	}
-
 	servconn->fd = source;
 
 	if (source >= 0)


More information about the Commits mailing list