pidgin: 44b8671d: I don't believe message should ever be n...

markdoliner at pidgin.im markdoliner at pidgin.im
Mon Nov 24 21:10:22 EST 2008


-----------------------------------------------------------------
Revision: 44b8671d6dd8deb34b4673bf6d3d334f9d614e56
Ancestor: 44585f354a7d61960d2e3d0b2d6c9e824b22107e
Author: markdoliner at pidgin.im
Date: 2008-11-25T02:08:22
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/44b8671d6dd8deb34b4673bf6d3d334f9d614e56

Modified files:
        libpurple/protocols/msn/soap.c

ChangeLog: 

I don't believe message should ever be null

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/soap.c	8e6a5f68de04593bee041d7a89b3c9f4fa1d27c9
+++ libpurple/protocols/msn/soap.c	480672fdbcb80a7f7b419df28a81e45f50c0b805
@@ -84,14 +84,12 @@ msn_soap_message_destroy(MsnSoapMessage 
 static void
 msn_soap_message_destroy(MsnSoapMessage *message)
 {
-	if (message) {
-		g_slist_foreach(message->headers, (GFunc)g_free, NULL);
-		g_slist_free(message->headers);
-		g_free(message->action);
-		if (message->xml)
-			xmlnode_free(message->xml);
-		g_free(message);
-	}
+	g_slist_foreach(message->headers, (GFunc)g_free, NULL);
+	g_slist_free(message->headers);
+	g_free(message->action);
+	if (message->xml)
+		xmlnode_free(message->xml);
+	g_free(message);
 }
 
 static void
@@ -265,6 +263,8 @@ msn_soap_message_send(MsnSession *sessio
 	const char *host, const char *path, gboolean secure,
 	MsnSoapCallback cb, gpointer cb_data)
 {
+	g_return_if_fail(message != NULL);
+
 	msn_soap_message_send_internal(session, message, host, path, secure,
 		cb, cb_data, FALSE);
 }


More information about the Commits mailing list