pidgin: a1d84026: Send the "client-accepts-full-bind-resul...

rekkanoryo at pidgin.im rekkanoryo at pidgin.im
Sat Nov 29 14:55:33 EST 2008


-----------------------------------------------------------------
Revision: a1d840261bdbafa8c9ceb77d53f385890f1b890f
Ancestor: febf4b9b295ca2c17faaa8db3cc410a6d027dc2a
Author: paul at aurich.com
Date: 2008-11-29T19:44:57
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/a1d840261bdbafa8c9ceb77d53f385890f1b890f

Modified files:
        ChangeLog libpurple/protocols/jabber/auth.c

ChangeLog: 

Send the "client-accepts-full-bind-result" attribute for Google Talk when
using SASL auth.  This prevents errors when people with googlemail.com accounts
add their account using the gmail.com domain or similar.  Fixes #6949.

-------------- next part --------------
============================================================
--- ChangeLog	27cad8ee21d47b996efa09ba46004357293952f1
+++ ChangeLog	4cb7614df80e04abf4e108a31efd314cccb1e204
@@ -26,6 +26,9 @@ version 2.5.3 (??/??/????):
 	* Gadu-Gadu now does proper charset translations where needed (Adam
 	  Strzelecki)
 	* Quit trying to get user info for XMPP MUC's (Paul Aurich)
+	* Send "client-accepts-full-bind-result" attribute during SASL login for
+	  XMPP accounts.  Will fix Google Talk login failures if the user
+	  configures the wrong domain for his/her account.
 
 	Pidgin:
 	* On GTK+ 2.14 and higher, we're using the gtk-tooltip-delay setting
============================================================
--- libpurple/protocols/jabber/auth.c	3edd7f889379139a3fb0da6e9a0810c224b54384
+++ libpurple/protocols/jabber/auth.c	d75ceb2ff8ff43a28fbff6f6ed10961ee65c96e9
@@ -397,6 +397,10 @@ static void jabber_auth_start_cyrus(Jabb
 		auth = xmlnode_new("auth");
 		xmlnode_set_namespace(auth, "urn:ietf:params:xml:ns:xmpp-sasl");
 		xmlnode_set_attrib(auth, "mechanism", js->current_mech);
+		
+		xmlnode_set_attrib(auth, "xmlns:ga", "http://www.google.com/talk/protocol/auth");
+		xmlnode_set_attrib(auth, "ga:client-uses-full-bind-result", "true");
+
 		if (clientout) {
 			if (coutlen == 0) {
 				xmlnode_insert_data(auth, "=", -1);


More information about the Commits mailing list