pidgin: 58fbcc16: Remove a bug where host_ip was accessed ...

sulabh at soc.pidgin.im sulabh at soc.pidgin.im
Wed Apr 15 11:51:03 EDT 2009


-----------------------------------------------------------------
Revision: 58fbcc161c5eadf3f307cd460a6ce0a209d908df
Ancestor: 4dcf57d47a73223c7c72ea9404107b71d7daac4f
Author: sulabh at soc.pidgin.im
Date: 2009-04-15T15:46:31
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/58fbcc161c5eadf3f307cd460a6ce0a209d908df

Modified files:
        libpurple/protocols/yahoo/yahoo.c

ChangeLog: 

Remove a bug where host_ip was accessed after freeing it.
This should prevent yahoo prpl crashes. I wonder how such a simple mistake escaped me for so long.

-------------- next part --------------
============================================================
--- libpurple/protocols/yahoo/yahoo.c	88f6b6912d8c1025cf696355a33671809cf398dd
+++ libpurple/protocols/yahoo/yahoo.c	1cd635b22cb060bad8cfed066ba40856f959f275
@@ -2973,8 +2973,10 @@ static void yahoo_process_p2p(PurpleConn
 
 		/* connect to host */
 		if((purple_proxy_connect(NULL, account, host_ip, YAHOO_PAGER_PORT_P2P, yahoo_p2p_init_cb, p2p_data))==NULL)	{
-			yahoo_p2p_disconnect_destroy_data(p2p_data);
 			purple_debug_info("yahoo","p2p: Connection to %s failed\n", host_ip);
+			g_free(p2p_data->host_ip);
+			g_free(p2p_data->host_username);
+			g_free(p2p_data);
 		}
 	}
 }


More information about the Commits mailing list