pidgin: 9c744758: cert: This a bad idea. check_subject_nam...

[darkrain42 at pidgin.im]

-----------------------------------------------------------------
Revision: 9c744758af256d9c652882ac815d5b81c710f701
Ancestor: bee5bfb6d563954d26ac9abd0cfbdc39b869a2f5
Author: darkrain42 at pidgin.im
Date: 2009-08-04T04:03:29
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/9c744758af256d9c652882ac815d5b81c710f701

Modified files:
        libpurple/certificate.c

ChangeLog: 

cert: This a bad idea. check_subject_name being mandatory to implement is IMHO much better.

-------------- next part --------------
============================================================
--- libpurple/certificate.c	cccd38f58b31c6a00eea3559a58046ef02fc7224
+++ libpurple/certificate.c	d59c97d4aea7386f7f1a2d82fc77d4155285f6ba
@@ -386,7 +386,6 @@ purple_certificate_check_subject_name(Pu
 
 	scheme = crt->scheme;
 
-	/* TODO: Instead of failing, maybe use get_subject_name and strcmp? */
 	g_return_val_if_fail(scheme->check_subject_name, FALSE);
 
 	return (scheme->check_subject_name)(crt, name);