pidgin: 468be347: The amount of indirection in the msn prp...

markdoliner at pidgin.im markdoliner at pidgin.im
Wed Aug 12 21:38:06 EDT 2009


-----------------------------------------------------------------
Revision: 468be347a493f33d93941ee15454b88a9cd44f3e
Ancestor: 6259477a6d23c25fe2dc52682028b524663cf028
Author: markdoliner at pidgin.im
Date: 2009-08-13T01:31:15
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/468be347a493f33d93941ee15454b88a9cd44f3e

Modified files:
        libpurple/protocols/msn/directconn.c

ChangeLog: 

The amount of indirection in the msn prpl bothers me, so I'm flatteneing
this call chain one level

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/directconn.c	f4f13ce115faa3d1b17831c7496bd854328938b0
+++ libpurple/protocols/msn/directconn.c	0d0bf0b5ab819d853d38bc2d576895424b7e1ab3
@@ -247,14 +247,6 @@ static void
 }
 
 static void
-msn_directconn_process_msg(MsnDirectConn *directconn, MsnMessage *msg)
-{
-	purple_debug_info("msn", "directconn: process_msg\n");
-
-	msn_slplink_process_msg(directconn->slplink, msg);
-}
-
-static void
 read_cb(gpointer data, gint source, PurpleInputCondition cond)
 {
 	MsnDirectConn* directconn;
@@ -337,7 +329,8 @@ read_cb(gpointer data, gint source, Purp
 		msg = msn_message_new_msnslp();
 		msn_message_parse_slp_body(msg, body, body_len);
 
-		msn_directconn_process_msg(directconn, msg);
+		purple_debug_info("msn", "directconn: process_msg\n");
+		msn_slplink_process_msg(directconn->slplink, msg);
 	}
 	else
 	{


More information about the Commits mailing list