pidgin: 778c6dd9: This is annoying, but am I actually miss...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Fri Aug 14 01:26:41 EDT 2009


-----------------------------------------------------------------
Revision: 778c6dd926828675b8a50a504d89328079eb8548
Ancestor: 1332a55a83e096d17b3cf9a8cb82f0595039e4fa
Author: darkrain42 at pidgin.im
Date: 2009-08-14T05:20:24
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/778c6dd926828675b8a50a504d89328079eb8548

Modified files:
        libpurple/protocols/jabber/caps.c

ChangeLog: 

This is annoying, but am I actually missing anything?

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/caps.c	0ba18c47448c0685ea295f0778b144020680ec5a
+++ libpurple/protocols/jabber/caps.c	c20424cf7e368864b5c2ba22d4da0be9efdf8e5b
@@ -456,6 +456,11 @@ jabber_caps_client_iqcb(JabberStream *js
 	/* Only validate if these are v1.5 capabilities */
 	if (userdata->hash) {
 		gchar *hash = NULL;
+		/*
+		 * TODO: If you add *any* hash here, make sure the checksum buffer
+		 * size in jabber_caps_calculate_hash is large enough. The cipher API
+		 * doesn't seem to offer a "Get the hash size" function(?).
+		 */
 		if (!strcmp(userdata->hash, "sha-1")) {
 			hash = jabber_caps_calculate_hash(info, "sha1");
 		} else if (!strcmp(userdata->hash, "md5")) {


More information about the Commits mailing list