pidgin: 39fc4acd: Fix setting the alias on a metacontact w...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Sat Aug 15 23:25:53 EDT 2009


-----------------------------------------------------------------
Revision: 39fc4acd81cf1796220d3ed4fff0b17bc5acf6de
Ancestor: 6729857f5490c9709931695c7a2bd8557f6eb832
Author: darkrain42 at pidgin.im
Date: 2009-08-16T03:23:54
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/39fc4acd81cf1796220d3ed4fff0b17bc5acf6de

Modified files:
        pidgin/gtkblist.c

ChangeLog: 

Fix setting the alias on a metacontact when it's not expanded. This is a patch.

-------------- next part --------------
============================================================
--- pidgin/gtkblist.c	1b1969a6dadb65c559be512c2414e9b525eee343
+++ pidgin/gtkblist.c	74c60e7240429a0d17752b18360f67c15524ce36
@@ -622,7 +622,14 @@ static void gtk_blist_renderer_edited_cb
 				struct _pidgin_blist_node *gtknode =
 					(struct _pidgin_blist_node *)purple_blist_node_get_ui_data(node);
 
-				if (purple_contact_get_alias(contact) || gtknode->contact_expanded) {
+				/*
+				 * XXX Using purple_contact_get_alias here breaks because we
+				 * specifically want to check the contact alias only (i.e. not
+				 * the priority buddy, which purple_contact_get_alias does).
+				 * Adding yet another get_alias is evil, so figure this out
+				 * later :-P
+				 */
+				if (contact->alias || gtknode->contact_expanded) {
 					purple_blist_alias_contact(contact, arg2);
 					gtk_blist_auto_personize(purple_blist_node_get_parent(node), arg2);
 				} else {


More information about the Commits mailing list