pidgin: dc2fb6f2: Fix the Perl XMLNode API so that calls d...

[darkrain42 at pidgin.im]

-----------------------------------------------------------------
Revision: dc2fb6f2e0637cecc92ac096e55f1c7f5a33fdbd
Ancestor: 3d50a7d038631a61998bb6cd271ef5ca1ce06417
Author: deryni at pidgin.im
Date: 2009-08-18T06:23:44
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/dc2fb6f2e0637cecc92ac096e55f1c7f5a33fdbd

Modified files:
        ChangeLog.API libpurple/plugins/perl/common/XMLNode.xs

ChangeLog: 

Fix the Perl XMLNode API so that calls don't need to explicitly pass
the class when it doesn't make sense (and lengths are never passed).

Fixes #9931 (more or less).

-------------- next part --------------
============================================================
--- ChangeLog.API	cf717ca4347c54f8e7960a8b203dc13e09373db3
+++ ChangeLog.API	b536bf616f182f425e0b12d38e9ceb20f8b54f1c
@@ -167,6 +167,12 @@ version 2.6.0 (??/??/2009):
 			* Purple::Request::Field::list_new
 			* Purple::Request::Field::string_new
 			* Purple::Request::Field::group_new
+		* Make the XMLNode API more perl-like. Don't pass len
+		  parameters and call them like:
+			* $xmlnode->copy()
+			* $xmlnode->to_str()
+			* $xmlnode->to_formatted_str()
+			* Purple::XMLNode::from_str(...)
 
 version 2.5.8 (06/27/2009):
 	No changes
============================================================
--- libpurple/plugins/perl/common/XMLNode.xs	7e85111d6408d39c15bde640d49d049ffc27b84d
+++ libpurple/plugins/perl/common/XMLNode.xs	8f7ab0eccc4250d089138446de9f85703fc50064
@@ -4,21 +4,16 @@ Purple::XMLNode
 PROTOTYPES: ENABLE
 
 Purple::XMLNode
-xmlnode_copy(class, src)
+xmlnode_copy(src)
 	Purple::XMLNode src
-    C_ARGS:
-	src
 
 void
 xmlnode_free(node)
 	Purple::XMLNode node
 
 Purple::XMLNode
-xmlnode_from_str(class, str, size)
-	const char *str
-	gssize size
-    C_ARGS:
-	str, size
+xmlnode_from_str(const char *str, gssize length(str))
+    PROTOTYPE: $
 
 const char *
 xmlnode_get_attrib(node, attr)
@@ -78,11 +73,17 @@ gchar_own *
 	const char *value
 
 gchar_own *
-xmlnode_to_formatted_str(node, len)
+xmlnode_to_formatted_str(node)
 	Purple::XMLNode node
-	int *len
+    CODE:
+	RETVAL = xmlnode_to_formatted_str(node, NULL);
+    OUTPUT:
+	RETVAL
 
 gchar_own *
-xmlnode_to_str(node, len)
+xmlnode_to_str(node)
 	Purple::XMLNode node
-	int *len
+    CODE:
+	RETVAL = xmlnode_to_str(node, NULL);
+    OUTPUT:
+	RETVAL