soc.2009.webkitmessageview: 6dd287c9: Inform the user about how the theme chan...

tdrhq at soc.pidgin.im tdrhq at soc.pidgin.im
Tue Aug 25 12:03:02 EDT 2009


-----------------------------------------------------------------
Revision: 6dd287c993bb1c69af9b763a20e0902a2be0aaf2
Ancestor: f2899c44cb09ec5157437b8877e2390ae7925ee3
Author: tdrhq at soc.pidgin.im
Date: 2009-08-10T17:45:16
Branch: im.pidgin.soc.2009.webkitmessageview
URL: http://d.pidgin.im/viewmtn/revision/info/6dd287c993bb1c69af9b763a20e0902a2be0aaf2

Modified files:
        pidgin/plugins/adiumthemes/webkit.c

ChangeLog: 

Inform the user about how the theme change takes effect.

-------------- next part --------------
============================================================
--- pidgin/plugins/adiumthemes/webkit.c	500890a0db5702a468fde431c77ba6da6e4c07a5
+++ pidgin/plugins/adiumthemes/webkit.c	2ad250d10672420e98ded0689cfa8c9d647678ef
@@ -809,9 +809,16 @@ style_changed (GtkWidget* combobox, gpoi
 style_changed (GtkWidget* combobox, gpointer null)
 {
 	char *name = gtk_combo_box_get_active_text (GTK_COMBO_BOX(combobox));
+	GtkWidget *dialog;
 
 	g_free (cur_style_dir);
 	cur_style_dir = name;
+
+	/* inform the user that existing conversations haven't changed */
+	dialog = gtk_message_dialog_new (NULL, 0, GTK_MESSAGE_INFO, GTK_BUTTONS_CLOSE, "The style for existing conversations have not been changed. Please close and re-open the conversation for the changes to take effect.");
+	g_assert (dialog);
+	gtk_widget_show (dialog);
+	g_signal_connect_swapped (dialog, "response", G_CALLBACK(gtk_widget_destroy), dialog);
 }
 
 static GtkWidget*
@@ -821,13 +828,14 @@ get_style_config_frame ()
 	GList *styles = get_style_directory_list (), *iter;
 	int index = 0, selected = 0;
 
-	for (iter = styles; iter; iter = g_list_next (iter), index++) {
+	for (iter = styles; iter; iter = g_list_next (iter)) {
 		PidginMessageStyle *style = pidgin_message_style_load (iter->data);
 		
 		if (style) {
 			gtk_combo_box_append_text (GTK_COMBO_BOX(combobox), iter->data);
 			if (g_str_equal (iter->data, cur_style_dir))
 				selected = index;
+			index++;
 			pidgin_message_style_unref (style);
 		}
 	}


More information about the Commits mailing list