pidgin: 12784690: Since the prefs variable holds the widge...

qulogic at pidgin.im qulogic at pidgin.im
Wed Dec 23 03:47:00 EST 2009


-----------------------------------------------------------------
Revision: 127846902276c5c3eb716c87088a6cad91c75f1a
Ancestor: 0277d523d234a53b4e9b8a5941c92f14845fc304
Author: qulogic at pidgin.im
Date: 2009-12-23T04:30:12
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/127846902276c5c3eb716c87088a6cad91c75f1a

Modified files:
        pidgin/gtkprefs.c

ChangeLog: 

Since the prefs variable holds the widget that refers to the prefs dialog,
it's still NULL in pidgin_prefs_init(), so using it for a handle is not a
good idea. Of course, the prefs connection is never removed, so it's not
that big of a deal.

-------------- next part --------------
============================================================
--- pidgin/gtkprefs.c	351b0ecd0b8608799eb8e525e7857a368403264e
+++ pidgin/gtkprefs.c	5ff8516c68ae90b3d4ba168c9881c5652ba0082d
@@ -2860,7 +2860,7 @@ pidgin_prefs_init(void)
 	purple_prefs_add_string(PIDGIN_PREFS_ROOT "/smileys/theme", "Default");
 
 	/* Smiley Callbacks */
-	purple_prefs_connect_callback(prefs, PIDGIN_PREFS_ROOT "/smileys/theme",
+	purple_prefs_connect_callback(&prefs, PIDGIN_PREFS_ROOT "/smileys/theme",
 								smiley_theme_pref_cb, NULL);
 
 	pidgin_prefs_update_old();


More information about the Commits mailing list