cpw.darkrain42.xmpp.iq-handlers: baaa6148: These checks are redundant; id is guaran...

paul at darkrain42.org paul at darkrain42.org
Tue Feb 10 01:20:27 EST 2009


-----------------------------------------------------------------
Revision: baaa6148419d57d9da8fbdb7e6d4ff4ce2fb2fff
Ancestor: 9b12a117d3405aa2b6f435356f978b2019357d62
Author: paul at darkrain42.org
Date: 2009-02-10T06:15:27
Branch: im.pidgin.cpw.darkrain42.xmpp.iq-handlers
URL: http://d.pidgin.im/viewmtn/revision/info/baaa6148419d57d9da8fbdb7e6d4ff4ce2fb2fff

Modified files:
        libpurple/protocols/jabber/iq.c

ChangeLog: 

These checks are redundant; id is guaranteed to be something above

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/iq.c	246373851ec892116e7e4513348ef743a0dfad2d
+++ libpurple/protocols/jabber/iq.c	6489c3efcd44261866bcbfa0c15c168ef913108a
@@ -352,7 +352,7 @@ void jabber_iq_parse(JabberStream *js, x
 
 	/* First, lets see if a special callback got registered */
 	if(type == JABBER_IQ_RESULT || type == JABBER_IQ_ERROR) {
-		if(id && *id && (jcd = g_hash_table_lookup(js->iq_callbacks, id))) {
+		if(jcd = g_hash_table_lookup(js->iq_callbacks, id)) {
 			jcd->callback(js, packet, jcd->data);
 			jabber_iq_remove_callback_by_id(js, id);
 			return;


More information about the Commits mailing list