pidgin.vv: dca923f5: disapproval of revision '1fa05b8b4d06972...

[malu at pidgin.im]

-----------------------------------------------------------------
Revision: dca923f5c49ff1a1638b3ac1529f82d846737578
Ancestor: 1fa05b8b4d069723f0cba486203a2a00c3baf096
Author: malu at pidgin.im
Date: 2009-01-10T01:26:45
Branch: im.pidgin.pidgin.vv
URL: http://d.pidgin.im/viewmtn/revision/info/dca923f5c49ff1a1638b3ac1529f82d846737578

Modified files:
        libpurple/media.c pidgin/gtkprefs.c

ChangeLog: 

disapproval of revision '1fa05b8b4d069723f0cba486203a2a00c3baf096'
-------------- next part --------------
============================================================
--- libpurple/media.c	ace1525a6274e3b80cffb467edbc664aecc4bf78
+++ libpurple/media.c	aa453673acb28aa529d040f9945e9ccce3c1c00c
@@ -1307,15 +1307,6 @@ purple_media_get_stun_pref_ip()
 	return purple_media_get_ip(stun_pref);
 }
 
-static gchar *
-purple_media_get_turn_pref_ip()
-{
-	const gchar *turn_pref =
-			purple_prefs_get_string("/purple/network/turn_server");
-	
-	return purple_media_get_ip(turn_pref);
-}
-
 static gboolean
 purple_media_add_stream_internal(PurpleMedia *media, const gchar *sess_id,
 				 const gchar *who, FsMediaType type,
@@ -1399,17 +1390,11 @@ purple_media_add_stream_internal(PurpleM
 
 	if (!stream) {
 		GError *err = NULL;
+		gchar *stun_ip = NULL;
 		FsStream *fsstream = NULL;
 
-		gchar *stun_ip = purple_media_get_stun_pref_ip();
-		gchar *turn_ip = purple_media_get_turn_pref_ip();
-		
-		if (stun_ip || turn_ip) {
-			int new_num_params = 
-				(stun_ip != NULL && turn_ip == NULL) || 
-				(stun_ip == NULL && turn_ip != NULL) ? 
-				num_params + 1 : num_params + 2;
-			GParameter *param = g_new0(GParameter, new_num_params);
+		if ((stun_ip = purple_media_get_stun_pref_ip())) {
+			GParameter *param = g_new0(GParameter, num_params+1);
 			memcpy(param, params, sizeof(GParameter) * num_params);
 
 			param[num_params].name = "stun-ip";
@@ -1418,12 +1403,9 @@ purple_media_add_stream_internal(PurpleM
 
 			fsstream = fs_session_new_stream(session->session,
 					participant, type_direction,
-					transmitter, new_num_params, param, &err);
+					transmitter, num_params+1, param, &err);
 			g_free(param);
-			if (stun_ip)
-				g_free(stun_ip);
-			if (turn_ip)
-				g_free(turn_ip);
+			g_free(stun_ip);
 		} else {
 			fsstream = fs_session_new_stream(session->session,
 					participant, type_direction,
============================================================
--- pidgin/gtkprefs.c	02b7dab253b8cef73c7cd7755092f145a79c2db0
+++ pidgin/gtkprefs.c	7459f4bea8cbf951be3bf717ab67e44c5028db91
@@ -2613,10 +2613,7 @@ pidgin_prefs_init(void)
 	/* set a default port for TURN server */
 	/* currently there is no default port for TURN, one option is to use the
 	 same port as STUN */
-	purple_prefs_add_string("/purple/network/turn_server", "");
 	purple_prefs_add_int("/purple/network/turn_port", 3478);
-	purple_prefs_add_string("/purple/network/turn_username", "");
-	purple_prefs_add_string("/purple/network/turn_password", "");
 
 	pidgin_prefs_update_old();
 }