pidgin: 42f77b0e: Jan Kratochvil found another race condit...
datallah at pidgin.im
datallah at pidgin.im
Wed Jan 14 23:01:33 EST 2009
-----------------------------------------------------------------
Revision: 42f77b0e8b8ebf5ff3c30d8f8022ac5d289631e8
Ancestor: a74b1f153eae510566148ee5430cbd11c02c1832
Author: datallah at pidgin.im
Date: 2009-01-15T03:56:58
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/42f77b0e8b8ebf5ff3c30d8f8022ac5d289631e8
Modified files:
pidgin/pidgintooltip.c
ChangeLog:
Jan Kratochvil found another race condition in the treeview tooltip code, this fixes it. Fixes #8069.
-------------- next part --------------
============================================================
--- pidgin/pidgintooltip.c 4c73086bdd764f8f39c616f19c80c886796b360d
+++ pidgin/pidgintooltip.c 15792b2164f75d2c03f68fbc71941d4cee733826
@@ -82,7 +82,8 @@ destroy_tooltip_data(PidginTooltipData *
static void
destroy_tooltip_data(PidginTooltipData *data)
{
- gtk_tree_path_free(data->common.treeview.path);
+ if (data->common.treeview.path)
+ gtk_tree_path_free(data->common.treeview.path);
pidgin_tooltip_destroy();
g_free(data);
}
@@ -380,7 +381,7 @@ gboolean pidgin_tooltip_setup_for_widget
g_signal_connect(G_OBJECT(widget), "motion-notify-event", G_CALLBACK(widget_motion_cb), wdata);
g_signal_connect(G_OBJECT(widget), "leave-notify-event", G_CALLBACK(widget_leave_cb), NULL);
- g_signal_connect_swapped(G_OBJECT(widget), "destroy", G_CALLBACK(g_free), wdata);
+ g_signal_connect_swapped(G_OBJECT(widget), "destroy", G_CALLBACK(destroy_tooltip_data), wdata);
return TRUE;
}
More information about the Commits
mailing list