cpw.darkrain42.xmpp.avatars: fd812d7a: Don't leak a JabberBuddyAvatarUpdateURLI...

paul at darkrain42.org paul at darkrain42.org
Fri Jan 23 22:28:30 EST 2009


-----------------------------------------------------------------
Revision: fd812d7a888de06f4277dce064bfc552b7e9069a
Ancestor: 1229f94c6a6799d5d21d10ff49f085d4143f052d
Author: paul at darkrain42.org
Date: 2009-01-21T17:56:07
Branch: im.pidgin.cpw.darkrain42.xmpp.avatars
URL: http://d.pidgin.im/viewmtn/revision/info/fd812d7a888de06f4277dce064bfc552b7e9069a

Modified files:
        libpurple/protocols/jabber/useravatar.c

ChangeLog: 

Don't leak a JabberBuddyAvatarUpdateURLInfo struct in the error case

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/useravatar.c	d99bd044ab28822d6eb5767208841acde8c376fc
+++ libpurple/protocols/jabber/useravatar.c	3f6d2ed2616945ff8dfa2aca1db8c7f7810cf7ab
@@ -174,10 +174,12 @@ do_buddy_avatar_update_fromurl(PurpleUti
 		purple_debug(PURPLE_DEBUG_ERROR, "jabber",
 		             "do_buddy_avatar_update_fromurl got error \"%s\"",
 		             error_message);
-		return;
+		goto out;
 	}
 	
 	purple_buddy_icons_set_for_user(purple_connection_get_account(info->js->gc), info->from, (void*)url_text, len, info->id);
+
+out:
 	g_free(info->from);
 	g_free(info->id);
 	g_free(info);


More information about the Commits mailing list