pidgin.next.minor: e5d32f52: Add a comment

markdoliner at pidgin.im markdoliner at pidgin.im
Sun Jan 25 18:30:37 EST 2009


-----------------------------------------------------------------
Revision: e5d32f52ad1dc6c9bb101dd07a018cccc2bb0f38
Ancestor: b6c989d9eb369844aa080313f725fddb494b4445
Author: markdoliner at pidgin.im
Date: 2009-01-25T23:25:11
Branch: im.pidgin.pidgin.next.minor
URL: http://d.pidgin.im/viewmtn/revision/info/e5d32f52ad1dc6c9bb101dd07a018cccc2bb0f38

Modified files:
        pidgin/gtksmiley.c

ChangeLog: 

Add a comment

-------------- next part --------------
============================================================
--- pidgin/gtksmiley.c	6b6e933b609898aaa7fb927440344dd0b7a754dd
+++ pidgin/gtksmiley.c	c6ac35c207e6d700e52e3394d5764f98e2509781
@@ -225,6 +225,12 @@ static void do_add(GtkWidget *widget, Pi
 
 	entry = gtk_entry_get_text(GTK_ENTRY(s->smile));
 	if (!entry || !*entry) {
+		/*
+		 * TODO: We should enable/disable the add button based on
+		 *       whether the user has entered all required data.  That
+		 *       would eliminate the need for this check and provide a
+		 *       better user experience.
+		 */
 		purple_notify_error(s->parent, _("Custom Smiley"),
 				_("More Data needed"),
 				_("Please provide a shortcut to associate with the smiley."));


More information about the Commits mailing list