pidgin.next.minor: 91321b70: Add a comment just noting that I think i...

markdoliner at pidgin.im markdoliner at pidgin.im
Wed Jan 28 14:30:44 EST 2009


-----------------------------------------------------------------
Revision: 91321b70a887f4ea293901d8dcb03de7f301595e
Ancestor: 72e4d1d897942fd7636eb3e98bfe03b2a51deb70
Author: markdoliner at pidgin.im
Date: 2009-01-28T19:26:43
Branch: im.pidgin.pidgin.next.minor
URL: http://d.pidgin.im/viewmtn/revision/info/91321b70a887f4ea293901d8dcb03de7f301595e

Modified files:
        pidgin/gtkimhtml.c

ChangeLog: 

Add a comment just noting that I think it's kind of annoying that we
have to do so much crap just to make a newline add a newline

-------------- next part --------------
============================================================
--- pidgin/gtkimhtml.c	9847be3e8cf6f722e082548d3902f8c0fb6f8869
+++ pidgin/gtkimhtml.c	cdfdf2f2269f3d890733a96c1a255e98f98d44ab
@@ -5866,6 +5866,13 @@ static gboolean return_add_newline_cb(Gt
 	return TRUE;
 }
 
+/*
+ * It's kind of a pain that we need this function and the above just
+ * to reinstate the default GtkTextView behavior.  It might be better
+ * if GtkIMHtml didn't intercept the enter key and just required the
+ * application to deal with it--it's really not much more work than it
+ * is to connect to the current "message_send" signal.
+ */
 void gtk_imhtml_set_return_inserts_newline(GtkIMHtml *imhtml)
 {
 	g_signal_connect(G_OBJECT(imhtml), "message_send",


More information about the Commits mailing list