pidgin: 7b97d841: We shouldn't de-reference variables befo...

qulogic at pidgin.im qulogic at pidgin.im
Thu Jul 2 23:41:15 EDT 2009


-----------------------------------------------------------------
Revision: 7b97d841a19c9b963f89df8c80d49146355567c7
Ancestor: f6d52847cf0802d50198c3d9d02c02aa182ca50f
Author: qulogic at pidgin.im
Date: 2009-07-02T01:30:41
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/7b97d841a19c9b963f89df8c80d49146355567c7

Modified files:
        libpurple/protocols/msn/state.c

ChangeLog: 

We shouldn't de-reference variables before checking if they're not NULL.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/state.c	ef2431e1f5f7c9ba6d82a7a635eb4dd1f1903e7d
+++ libpurple/protocols/msn/state.c	fafd08c40588a2ede758a1ce9521876e5fe2261c
@@ -249,7 +249,7 @@ msn_set_psm(MsnSession *session)
 void
 msn_set_psm(MsnSession *session)
 {
-	PurpleAccount *account = session->account;
+	PurpleAccount *account;
 	PurplePresence *presence;
 	PurpleStatus *status;
 	MsnCmdProc *cmdproc;
@@ -261,6 +261,7 @@ msn_set_psm(MsnSession *session)
 	g_return_if_fail(session != NULL);
 	g_return_if_fail(session->notification != NULL);
 
+	account = session->account;
 	cmdproc = session->notification->cmdproc;
 
 	/* Get the PSM string from Purple's Status Line */


More information about the Commits mailing list