pidgin: a005829c: Add a comment about some strange behavio...

markdoliner at pidgin.im markdoliner at pidgin.im
Mon Jul 6 19:30:41 EDT 2009


-----------------------------------------------------------------
Revision: a005829cf6a7f1c1e1d08a9ed295691a6f711a33
Ancestor: 39ce94eb5089a92b691f8b51d6a5b742042d913e
Author: markdoliner at pidgin.im
Date: 2009-07-06T23:24:37
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/a005829cf6a7f1c1e1d08a9ed295691a6f711a33

Modified files:
        libpurple/protocols/qq/buddy_info.c

ChangeLog: 

Add a comment about some strange behavior that I noticed

-------------- next part --------------
============================================================
--- libpurple/protocols/qq/buddy_info.c	a684715078b8936574cf2345cedd5a341c09c5cc
+++ libpurple/protocols/qq/buddy_info.c	9e147435e11520bdc8d2b188a9a7f5046ea89a6b
@@ -530,6 +530,15 @@ gchar *qq_get_icon_name(gint face)
 	return icon_name;
 }
 
+/*
+ * Hmm, this function is a bit weird.
+ * 1. The pref "/plugins/prpl/qq/icon_dir" doesn't exist
+ * 2. QQ_BUDDY_ICON_DIR is set in Makefile.am, but it's set to a
+ *    directory that doesn't exist
+ * 3. Why would the icon path be different for Windows and Linux?
+ * 4. Why do we use this in the first place?  Setting your icon
+ *    should go through the account editor.
+ */
 gchar *qq_get_icon_path(gchar *icon_name)
 {
 	gchar *icon_path;


More information about the Commits mailing list