pidgin: 7560694d: Fix a leak of the queued_requests from p...

[darkrain42 at pidgin.im]

-----------------------------------------------------------------
Revision: 7560694d015e08baebe1dca2f623d653da1d52af
Ancestor: 525b0e0a2e4dafdfa55b73e359709415f79bd872
Author: aman at tmm1.net
Date: 2009-07-11T21:28:58
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/7560694d015e08baebe1dca2f623d653da1d52af

Modified files:
        COPYRIGHT ChangeLog libpurple/dnsquery.c

ChangeLog: 

Fix a leak of the queued_requests from purple_dnsquery_a.

Patch from Aman "tmm1" Gupta.

-------------- next part --------------
============================================================
--- COPYRIGHT	e8295a63c15a37621a45b1a93a97c3a65b774f9b
+++ COPYRIGHT	75d39a2309992c1ee086e408bb553f1378bb54e0
@@ -171,6 +171,7 @@ Gideon N. Guillen
 Christian Grothoff
 Vladislav Guberini?
 Gideon N. Guillen
+Aman Gupta
 Christian Hammond
 Erick Hamness
 Fred Hampton
============================================================
--- ChangeLog	16b604e428236f384e15fe8d6639102726ce36ad
+++ ChangeLog	b7b872e9fc86c18b1a5267f93d1ccb3239203b64
@@ -30,6 +30,8 @@ version 2.6.0 (??/??/2009):
 	* Don't do IPv6 address lookups if the computer does not have an IPv6
 	  address configured.
 	* Add support for receiving audio clips on MSN.
+	* Fix a leak when the UI provides its own DNS resolving UI op.
+	  (Aman Gupta)
 
 	AIM and ICQ:
 	* Preliminary support for a new authentication scheme called
@@ -45,7 +47,7 @@ version 2.6.0 (??/??/2009):
 	* Correctly show tooltip status for contacts with status messages.
 	  (Krzysztof "kkszysiu" Klinikowski)
 	* Support for fetching buddy icons.  (Krzysztof "kkszysiu" Klinikowski)
-	* Support connection progress steps in Gadu-Gadu (Krzysztof "kkszysiu"
+	* Support connection progress steps in Gadu-Gadu.  (Krzysztof "kkszysiu"
 	  Klinikowski)
 
 	XMPP:
============================================================
--- libpurple/dnsquery.c	9ee9cb81e40e9e195fdc5c16850d17c0d2512b0a
+++ libpurple/dnsquery.c	9e3d25b76b54c879b7fdad836c112d94a20424cf
@@ -77,6 +77,7 @@ static GSList *free_dns_children = NULL;
 };
 
 static GSList *free_dns_children = NULL;
+/* TODO: Make me a GQueue when we require >= glib 2.4 */
 static GSList *queued_requests = NULL;
 
 static int number_of_dns_children = 0;
@@ -621,6 +622,8 @@ resolve_host(gpointer data)
 		return FALSE;
 	}
 
+	queued_requests = g_slist_append(queued_requests, query_data);
+
 	handle_next_queued_request();
 
 	return FALSE;
@@ -650,8 +653,6 @@ purple_dnsquery_a(const char *hostname, 
 		g_return_val_if_reached(NULL);
 	}
 
-	queued_requests = g_slist_append(queued_requests, query_data);
-
 	purple_debug_info("dns", "DNS query for '%s' queued\n", query_data->hostname);
 
 	query_data->timeout = purple_timeout_add(0, resolve_host, query_data);