pidgin: c276e3e4: Fix a crash with the Message Notificatio...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Sat Jul 18 03:40:50 EDT 2009


-----------------------------------------------------------------
Revision: c276e3e40bea98e6a7a25bc928400a5d0c76e340
Ancestor: 6543699e5f6e245ea5a903f2ee37d94f130fd66a
Author: darkrain42 at pidgin.im
Date: 2009-07-18T05:08:25
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/c276e3e40bea98e6a7a25bc928400a5d0c76e340

Modified files:
        ChangeLog pidgin/plugins/notify.c

ChangeLog: 

Fix a crash with the Message Notification plugin and the 'hidden' gtkconv

So I was finally able to reproduce this. "Close IMs immediately" was
disabled and in the Message Notification plugin's settings, everything
is disabled except "[Notify for ]IM windows" and
"Present conversation window".

In my testing, this did not prevent the conversation from re-attaching
when a new message comes on. Fixes #8911.

-------------- next part --------------
============================================================
--- ChangeLog	0e017ce9ba387960955751183b26918d58ec657c
+++ ChangeLog	54b84212be7bac9191b67a121953e509ab08274c
@@ -156,6 +156,8 @@ version 2.6.0 (??/??/2009):
 	  (Kosta Arvanitis)
 	* When file transfers are complete, the received file name written to the
 	  conversation window is now linked to the file.
+	* Fix a crash when closing a conversation tab that has unread messages
+	  when the Message Notification plugin is loaded.
 
 	Finch:
 	* The hardware cursor is updated correctly. This will be useful
============================================================
--- pidgin/plugins/notify.c	52f45832a84a4e9ab89cb5a1efbf9239cab7650d
+++ pidgin/plugins/notify.c	536ff7f9432a6645d9a53fc4d2b574981cb17903
@@ -572,6 +572,9 @@ handle_present(PurpleConversation *conv)
 static void
 handle_present(PurpleConversation *conv)
 {
+	if (pidgin_conv_is_hidden(PIDGIN_CONVERSATION(conv)))
+		return;
+
 	purple_conversation_present(conv);
 }
 


More information about the Commits mailing list