pidgin: 826fe96c: ALLOW_TAG expands to multiple statements...

qulogic at pidgin.im qulogic at pidgin.im
Sun Jul 19 04:20:47 EDT 2009


-----------------------------------------------------------------
Revision: 826fe96cf74adec56a74a298023c17a9eece9c8b
Ancestor: 709e6a377c6f28283c73e7debfbd9611c5f6d415
Author: qulogic at pidgin.im
Date: 2009-07-19T08:09:24
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/826fe96cf74adec56a74a298023c17a9eece9c8b

Modified files:
        libpurple/util.c

ChangeLog: 

ALLOW_TAG expands to multiple statements, so we should put braces around
this if(). Otherwise, I think we'd accept <html/> in the middle of the
markup.

References #7340.

-------------- next part --------------
============================================================
--- libpurple/util.c	a245ad53a854b490fc9055f290ea197553d77db9
+++ libpurple/util.c	e49ae7f95074cb08e23f05604395f897703bfea9
@@ -1572,8 +1572,9 @@ purple_markup_html_to_xhtml(const char *
 				ALLOW_TAG("h5");
 				ALLOW_TAG("h6");
 				/* we only allow html to start the message */
-				if(c == html)
+				if(c == html) {
 					ALLOW_TAG("html");
+				}
 				ALLOW_TAG_ALT("i", "em");
 				ALLOW_TAG_ALT("italic", "em");
 				ALLOW_TAG("li");


More information about the Commits mailing list