pidgin: 4a104379: Returning FALSE from a function that is ...

deryni at pidgin.im deryni at pidgin.im
Tue Jul 21 19:50:47 EDT 2009


-----------------------------------------------------------------
Revision: 4a104379b50ca6932553b584b1cb7a06e008be23
Ancestor: 6b146c92bd0f878c7321a914c74044d50273abcf
Author: deryni at pidgin.im
Date: 2009-07-10T04:35:20
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/4a104379b50ca6932553b584b1cb7a06e008be23

Modified files:
        libpurple/blist.c

ChangeLog: 

Returning FALSE from a function that is suposed to return a PurpleChat * is
very wrong.

-------------- next part --------------
============================================================
--- libpurple/blist.c	a186cba632bf7bbd1688dce209ebb46236eafd36
+++ libpurple/blist.c	b9db685e22f05a9cb795bb37f2a432370867c14a
@@ -1278,8 +1278,8 @@ PurpleChat *purple_chat_new(PurpleAccoun
 	PurpleBlistUiOps *ops = purple_blist_get_ui_ops();
 	PurpleChat *chat;
 
-	g_return_val_if_fail(account != NULL, FALSE);
-	g_return_val_if_fail(components != NULL, FALSE);
+	g_return_val_if_fail(account != NULL, NULL);
+	g_return_val_if_fail(components != NULL, NULL);
 
 	chat = g_new0(PurpleChat, 1);
 	chat->account = account;


More information about the Commits mailing list