pidgin: 5873a30d: Set xfer->status before emitting signals...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Wed Jul 22 22:56:04 EDT 2009


-----------------------------------------------------------------
Revision: 5873a30d6730c89c80e446a7c96585ee32555e3a
Ancestor: 181c5ea2c448b7bdce3f3e9dcfac31ef4d04f0f2
Author: darkrain42 at pidgin.im
Date: 2009-07-23T02:31:52
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/5873a30d6730c89c80e446a7c96585ee32555e3a

Modified files:
        ChangeLog.API libpurple/ft.c

ChangeLog: 

Set xfer->status before emitting signals in purple_xfer_set_status.

This was noticed by kenshin in #pidgin and doesn't interfere with
the autoaccept plugin (that signal is emitted in purple_xfer_request).

-------------- next part --------------
============================================================
--- ChangeLog.API	2004570ea33233779e05239c2cb444aa3c711271
+++ ChangeLog.API	7574953b156e26f6e01800461a07d82498cd8ddd
@@ -87,6 +87,7 @@ version 2.6.0 (??/??/2009):
 		* purple_find_group is now more efficient for large numbers of groups.
 		* All DNS routines support internationalized domain names (IDNs) when
 		  libpurple is compiled with GNU libidn.
+		* status is set before emitting signals in purple_xfer_set_status.
 
 		Deprecated:
 		* buddy-added and buddy-removed blist signals
============================================================
--- libpurple/ft.c	88aea75e43da3b1c64f266752992350e9dd7a9af
+++ libpurple/ft.c	47b955cbd744632a038af0a6025d74c49ee57c1b
@@ -132,6 +132,8 @@ purple_xfer_set_status(PurpleXfer *xfer,
 {
 	g_return_if_fail(xfer != NULL);
 
+	xfer->status = status;
+
 	if(xfer->type == PURPLE_XFER_SEND) {
 		switch(status) {
 			case PURPLE_XFER_STATUS_ACCEPTED:
@@ -169,8 +171,6 @@ purple_xfer_set_status(PurpleXfer *xfer,
 				break;
 		}
 	}
-
-	xfer->status = status;
 }
 
 void purple_xfer_conversation_write(PurpleXfer *xfer, char *message, gboolean is_error)


More information about the Commits mailing list