pidgin: a3717eb1: I don't understand how this branch could...

[qulogic at pidgin.im]

-----------------------------------------------------------------
Revision: a3717eb1e747cc7caf8d66691500664fb03e7b9b
Ancestor: 63785bc35c519d1a1061d0ad3b1b46a4d297ce87
Author: qulogic at pidgin.im
Date: 2009-07-31T02:48:57
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/a3717eb1e747cc7caf8d66691500664fb03e7b9b

Modified files:
        libpurple/protocols/msn/slplink.c

ChangeLog: 

I don't understand how this branch could be reached, but don't leak the slp
message if we get here. The two places that set slpcall->xfer also set
xfer->data, so this really shouldn't happen.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/slplink.c	60bf75e50500c7fc39ec2c03bd53f809866955ed
+++ libpurple/protocols/msn/slplink.c	8545314bddf319cd7d45fd0593c04b9d089bb618
@@ -541,7 +541,8 @@ msn_slplink_process_msg(MsnSlpLink *slpl
 
 						if (xfer->data == NULL) {
 							purple_xfer_unref(xfer);
-							return;
+							msn_slpmsg_destroy(slpmsg);
+							g_return_if_reached();
 						} else {
 							purple_xfer_unref(xfer);
 							slpmsg->fp = xfer->dest_fp;