pidgin: 50317363: Better variable name?

markdoliner at pidgin.im markdoliner at pidgin.im
Fri Jul 31 05:25:22 EDT 2009


-----------------------------------------------------------------
Revision: 50317363604b0866e352783989fd290507775a9f
Ancestor: 6da9520ac027d6503efb5c0f1cec75f90ff42669
Author: markdoliner at pidgin.im
Date: 2009-07-31T09:21:28
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/50317363604b0866e352783989fd290507775a9f

Modified files:
        libpurple/protocols/yahoo/util.c

ChangeLog: 

Better variable name?

-------------- next part --------------
============================================================
--- libpurple/protocols/yahoo/util.c	50046186bc4b40892d2a298ec6626a07e6fbe2c0
+++ libpurple/protocols/yahoo/util.c	1efb7b17af1f429f7436825bedf59671ded2dc8d
@@ -342,7 +342,7 @@ char *yahoo_codes_to_html(const char *x)
 	GString *s;
 	int i, j;
 	gchar *tmp;
-	gboolean no_more_end_tags = FALSE; /* s/endtags/closinganglebrackets */
+	gboolean no_more_lt_brackets = FALSE;
 	const char *match;
 
 	x_len = strlen(x);
@@ -350,8 +350,8 @@ char *yahoo_codes_to_html(const char *x)
 
 	for (i = 0; i < x_len; i++) {
 		if ((x[i] == 0x1b) && (x[i+1] == '[')) {
-			/* This is the beginning of an escape sequence, which
-			 * contains text formatting. */
+			/* This escape sequence signifies the beginning of some
+			 * text formatting code */
 			j = i + 1;
 
 			while (j++ < x_len) {
@@ -377,14 +377,15 @@ char *yahoo_codes_to_html(const char *x)
 				}
 			}
 
-		} else if (!no_more_end_tags && (x[i] == '<')) {
+		} else if (!no_more_lt_brackets && (x[i] == '<')) {
+			/* The start of an HTML tag */
 			j = i;
 
 			while (j++ < x_len) {
 				if (x[j] != '>')
 					if (j == x_len) {
 						g_string_append(s, "&lt;");
-						no_more_end_tags = TRUE;
+						no_more_lt_brackets = TRUE;
 					}
 					else
 						continue;


More information about the Commits mailing list