cpw.darkrain42.xmpp.disco: 22682355: khc: darkrain42: xmlnode not free'ed in ...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Wed Jun 3 02:06:03 EDT 2009


-----------------------------------------------------------------
Revision: 226823554fed7cb05810a5a8446141237a984e25
Ancestor: 962bd448c2425395084969c7da1ca785d37e598c
Author: darkrain42 at pidgin.im
Date: 2009-06-03T06:03:22
Branch: im.pidgin.cpw.darkrain42.xmpp.disco
URL: http://d.pidgin.im/viewmtn/revision/info/226823554fed7cb05810a5a8446141237a984e25

Modified files:
        libpurple/plugins/signals-test.c
        pidgin/plugins/disco/xmppdisco.c

ChangeLog: 

khc: darkrain42: xmlnode not free'ed in jabber_watched_iq
darkrain42: bah!

Turns out there was more than one not being freed...

-------------- next part --------------
============================================================
--- libpurple/plugins/signals-test.c	91808836d526c3dd2e3784a31d99110aceb77715
+++ libpurple/plugins/signals-test.c	87b5ba1505dbae0cb25cc63f76eac69d052b81b9
@@ -686,6 +686,7 @@ jabber_watched_iq(PurpleConnection *pc, 
 		prpl_info = PURPLE_PLUGIN_PROTOCOL_INFO(prpl);
 		prpl_info->send_raw(pc, str, -1);
 		g_free(str);
+		xmlnode_free(iq);
 	}
 
 	/* Cookie monster eats IQ stanzas; the prpl shouldn't keep processing */
============================================================
--- pidgin/plugins/disco/xmppdisco.c	c7b241b8c9644bc3bfe97d787ca465f6831aa6d8
+++ pidgin/plugins/disco/xmppdisco.c	f3a15d2c982d726d00facb4d310f25ab9824f8c9
@@ -164,6 +164,8 @@ xmpp_disco_info_do(PurpleConnection *pc,
 	prpl_info = PURPLE_PLUGIN_PROTOCOL_INFO(prpl);
 	prpl_info->send_raw(pc, str, -1);
 	g_free(str);
+	xmlnode_free(iq);
+	g_free(id);
 }
 
 static void
@@ -193,6 +195,8 @@ xmpp_disco_items_do(PurpleConnection *pc
 	prpl_info = PURPLE_PLUGIN_PROTOCOL_INFO(prpl);
 	prpl_info->send_raw(pc, str, -1);
 	g_free(str);
+	xmlnode_free(iq);
+	g_free(id);
 }
 
 static XmppDiscoServiceType
@@ -548,6 +552,7 @@ void xmpp_disco_service_register(XmppDis
 	prpl_info = PURPLE_PLUGIN_PROTOCOL_INFO(prpl);
 	prpl_info->send_raw(service->list->pc, str, -1);
 	g_free(str);
+	xmlnode_free(iq);
 	g_free(id);
 }
 


More information about the Commits mailing list