pidgin: 8806e5fb: Stop exiting early from this function. ...

markdoliner at markdoliner at
Wed Jun 3 17:50:31 EDT 2009

Revision: 8806e5fba5cdb38ef9be6799e7e829dc2a762a69
Ancestor: e9a74776399c7ddf335397e3602c809b60cb3864
Author: markdoliner at
Date: 2009-06-03T21:46:05
Branch: im.pidgin.pidgin

Modified files:


Stop exiting early from this function.  I don't believe it harms anything
to continue executing even if body is null, and if we exit early then
we don't call purple_connection_set_state(session->gc, PURPLE_CONNECTED)
and the account never gets set to "connected."  This seems to affect
any MySpace account that has an empty buddy list.

I'm pretty sure this used to work fine, so I'm assuming MySpace tweaked
the data sent to the client when the user has an empty buddy list.

-------------- next part --------------
--- libpurple/protocols/myspace/myspace.c	9891cd24a970ca416cb5be9d107b1e82fea993f5
+++ libpurple/protocols/myspace/myspace.c	e5821975e39bf9ff06fb52000310468e2ec5c1a2
@@ -1118,10 +1118,6 @@ msim_got_contact_list(MsimSession *sessi
 	guint buddy_count;
 	body = msim_msg_get_dictionary(reply, "body");
-	if (!body) {
-		/* No friends. Not an error. */
-		return;
-	}
 	buddy_count = 0;

More information about the Commits mailing list