pidgin: 5207c992: Use the JID for adding a chat/buddy beca..

qulogic at qulogic at
Mon Jun 8 00:35:38 EDT 2009

Revision: 5207c992dd364ac19c4eef4054eb1b9346bcd7d0
Ancestor: be31b2193ea41c6ab30443f2e1240f7faa0a25ac
Author: qulogic at
Date: 2009-06-08T02:24:49
Branch: im.pidgin.pidgin

Modified files:


Use the JID for adding a chat/buddy because the name is for descriptive
purpose only, and using it will not fill in the Add Chat dialog correctly.
Because the JID is not visible, the user will not know what to actually put
there instead.

-------------- next part --------------
--- pidgin/plugins/disco/gtkdisco.c	57dfe6b05e1db1b809a7e626f469304f637f325d
+++ pidgin/plugins/disco/gtkdisco.c	e014ea09768bf7a89a1014bdaa601e1ba74c7d50
@@ -216,17 +216,17 @@ static void add_room_to_blist_cb(GtkButt
 	struct _menu_cb_info *info = g_object_get_data(G_OBJECT(button), "disco-info");
 	PurpleAccount *account;
-	const char *name;
+	const char *jid;
 	g_return_if_fail(info != NULL);
 	account = purple_connection_get_account(info->list->pc);
-	name = info->service->name;
+	jid = info->service->jid;
 	if (info->service->type == XMPP_DISCO_SERVICE_TYPE_CHAT)
-		purple_blist_request_add_chat(account, NULL, NULL, name);
+		purple_blist_request_add_chat(account, NULL, NULL, jid);
-		purple_blist_request_add_buddy(account, name, NULL, NULL);
+		purple_blist_request_add_buddy(account, jid, NULL, NULL);
 static void

More information about the Commits mailing list