pidgin: 99d11681: Need to make a copy of this because purp...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Sun Jun 21 18:20:36 EDT 2009


-----------------------------------------------------------------
Revision: 99d11681eb284c0315d672c4282f39f175ca5d9e
Ancestor: e2bd07369c221038b091b908c8e07f0ae6179cd9
Author: darkrain42 at pidgin.im
Date: 2009-06-21T21:26:59
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/99d11681eb284c0315d672c4282f39f175ca5d9e

Modified files:
        libpurple/protocols/jabber/useravatar.c

ChangeLog: 

Need to make a copy of this because purple_util_fetch_url frees its.

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/useravatar.c	1089a0ec138047f19bce5f5e70859a150aee77d6
+++ libpurple/protocols/jabber/useravatar.c	c2acd8381f61a5e4c0c4ba7ef030b5e31b5ee298
@@ -257,6 +257,8 @@ do_buddy_avatar_update_fromurl(PurpleUti
                                gsize len, const gchar *error_message)
 {
 	JabberBuddyAvatarUpdateURLInfo *info = user_data;
+	gpointer icon_data;
+
 	if(!url_text) {
 		purple_debug(PURPLE_DEBUG_ERROR, "jabber",
 		             "do_buddy_avatar_update_fromurl got error \"%s\"",
@@ -264,7 +266,8 @@ do_buddy_avatar_update_fromurl(PurpleUti
 		goto out;
 	}
 
-	purple_buddy_icons_set_for_user(purple_connection_get_account(info->js->gc), info->from, (void*)url_text, len, info->id);
+	icon_data = g_memdup(url_text, len);
+	purple_buddy_icons_set_for_user(purple_connection_get_account(info->js->gc), info->from, icon_data, len, info->id);
 
 out:
 	g_free(info->from);


More information about the Commits mailing list