pidgin: fc684468: disapproval of revision '90bcee91e80ba05...

rekkanoryo at pidgin.im rekkanoryo at pidgin.im
Wed Mar 4 01:40:34 EST 2009


-----------------------------------------------------------------
Revision: fc6844685b98c3ba0c8860d00c057d51b436abf2
Ancestor: 90bcee91e80ba055eb211168b099418753e096e9
Author: rekkanoryo at pidgin.im
Date: 2009-03-04T06:33:39
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/fc6844685b98c3ba0c8860d00c057d51b436abf2

Modified files:
        ChangeLog pidgin/gtkconn.c

ChangeLog: 

disapproval of revision '90bcee91e80ba055eb211168b099418753e096e9'

khc points out that this isn't necessarily the best idea.  Refs #183.

-------------- next part --------------
============================================================
--- ChangeLog	f619413cf0a240cfcafee85c099ea0dccc4ee997
+++ ChangeLog	bdc1c2ed3bfccdee3b5b72d65c262b5db41de0d1
@@ -18,9 +18,6 @@ version 2.6.0 (??/??/2009):
 	* Pressing the Enter key in the message entry box of the New Status
 	  dialog and various other dialogs now causes the cursor to move to
 	  the next line.
-	* Authentication failures now clear the account password, causing Pidgin
-	  to prompt for the password when clicking the "Re-enable" button on the
-	  minidialog.
 
 version 2.5.5 (03/01/2009):
 	libpurple:
============================================================
--- pidgin/gtkconn.c	45fb8d7df0676e90d7fea7501835cdafa347af2d
+++ pidgin/gtkconn.c	9c65425207fe72d7140bc9bb166988997c257d45
@@ -163,11 +163,6 @@ pidgin_connection_report_disconnect_reas
 			g_hash_table_remove(auto_reconns, account);
 
 		purple_account_set_enabled(account, PIDGIN_UI, FALSE);
-
-		/* clear the saved password if this is an authentication failure */
-		if(reason == PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED)
-			purple_account_set_password(account, NULL);
-			
 	}
 
 	/* If we have any open chats, we probably want to rejoin when we get back online. */


More information about the Commits mailing list