pidgin: 9ae083b7: Add a note that this function could pote...

[markdoliner at pidgin.im]

-----------------------------------------------------------------
Revision: 9ae083b7093cb3dc764443a54dbb8d2abe84a0b8
Ancestor: a87c7d20cd4af1716e08f892a6a39895185f9f3e
Author: markdoliner at pidgin.im
Date: 2009-03-13T02:51:00
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/9ae083b7093cb3dc764443a54dbb8d2abe84a0b8

Modified files:
        libpurple/util.c

ChangeLog: 

Add a note that this function could potentially be faster.

-------------- next part --------------
============================================================
--- libpurple/util.c	e4dc9deaf75753ad9d3bf9b973fab8219a739c23
+++ libpurple/util.c	d6274467003e6a941f0ded2bf0084cba28184ea7
@@ -2850,6 +2850,12 @@ purple_util_get_image_extension(gconstpo
 	return "icon";
 }
 
+/*
+ * TODO: Consider using something faster than SHA-1, such as MD5, MD4
+ *       or CRC32.  Are there security implications to that?  Would
+ *       probably be a good idea to benchmark some algorithms with
+ *       3KB-10KB chunks of data (typical buddy icon sizes).
+ */
 char *
 purple_util_get_image_checksum(gconstpointer image_data, size_t image_len)
 {