pidgin: 72b4eba9: disapproval of revision '77d562b624d9b55...

qulogic at pidgin.im qulogic at pidgin.im
Sat Mar 28 04:05:45 EDT 2009


-----------------------------------------------------------------
Revision: 72b4eba9246c31efe0760a9e5d1eeb0f87da2867
Ancestor: 77d562b624d9b55c9ff165d5797b72ba553e3256
Author: qulogic at pidgin.im
Date: 2009-03-28T04:30:40
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/72b4eba9246c31efe0760a9e5d1eeb0f87da2867

Modified files:
        libpurple/nat-pmp.c libpurple/ntlm.c

ChangeLog: 

disapproval of revision '77d562b624d9b55c9ff165d5797b72ba553e3256'
Comments: 

You can't go randomly changing the size of network structures.

-------------- next part --------------
============================================================
--- libpurple/nat-pmp.c	5b621cd46d28fae0afb65891abe1f1e4e17dbd67
+++ libpurple/nat-pmp.c	4e4fb9bb4b636bae702827a77339dc3e6a679449
@@ -81,6 +81,8 @@ struct _PurplePmpMapResponse {
 struct _PurplePmpMapResponse {
 	guint8		version;
 	guint8		opcode;
+	guint16		resultcode;
+	guint32		epoch;
 	guint16		privateport;
 	guint16		publicport;
 	guint32		lifetime;
============================================================
--- libpurple/ntlm.c	104c414f7e16cc936bb12b731140f58e82d62482
+++ libpurple/ntlm.c	46f675b7f1e52a4a2ee35579770a6be9769533c6
@@ -59,9 +59,14 @@ struct type2_message {
 	guint8  protocol[8];     /* 'N', 'T', 'L', 'M', 'S', 'S', 'P', '\0'*/
 	guint32 type;            /* 0x00000002 */
 
+	short   msg_len1;        /* target name length */
+	short   msg_len2;        /* target name length */
+	guint32 msg_off;         /* target name offset (always 0x00000048) */
+
 	guint32 flags;           /* 0x00008201 */
 
 	guint8  nonce[8];        /* nonce */
+	guint8 context[8];
 };
 
 struct type3_message {


More information about the Commits mailing list