pidgin.2.5.6: c2b098e0: *** Plucked rev fade006b (malu at pidgin.im...

[darkrain42 at pidgin.im]

-----------------------------------------------------------------
Revision: c2b098e0aaf7e6fffec72b3130cb4c851c7a64c1
Ancestor: a4e91e84a8f8313c81aae1e3a4ec96f03953f28e
Author: darkrain42 at pidgin.im
Date: 2009-05-02T23:30:49
Branch: im.pidgin.pidgin.2.5.6
URL: http://d.pidgin.im/viewmtn/revision/info/c2b098e0aaf7e6fffec72b3130cb4c851c7a64c1

Modified files:
        ChangeLog libpurple/protocols/jabber/message.c

ChangeLog: 

*** Plucked rev fade006b (malu at pidgin.im):
Only pre-create a PurpleConversation (if there was none yet) if an incoming
message contains custom smileys.
Partly fixes the \"popup a conversation window when set to hide\" bug.
Until I found a better way to fix entirely...
Refs #7380

*** Plucked rev 120a0724 (darkrain42 at pidgin.im):
Only look for and add custom smileys to incoming messages that are going to
end up being displayed in a conversation window (i.e. not headline messages).
Closes #7516.


-------------- next part --------------
============================================================
--- ChangeLog	ab05c931008ac7fd7539cc6e78c75bad8fe99ea2
+++ ChangeLog	a18cc858d72040d9f535584842b7c176a6172e4b
@@ -20,6 +20,10 @@ version 2.5.6 (??/??/2009):
 	* Fix some errors about the friendly name changing too fast caused
 	  by MSN/Yahoo integration buddies.
 
+	XMPP:
+	* Less likely to pop up a new conversation window in disregard of
+	  the "Hide new IM conversations" preference.
+
 	Yahoo:
 	* Fix a crash when sending very long messages.
 
@@ -692,13 +696,13 @@ version 2.2.0 (09/13/2007):
 version 2.2.0 (09/13/2007):
 	http://developer.pidgin.im/query?status=closed&milestone=2.2.0
 
-	Libpurple:
+	libpurple:
 	* New protocol plugin: MySpaceIM (Jeff Connelly, Google Summer of
 	  Code)
 	* XMPP enhancements. See
-	  http://www.adiumx.com/blog/2007/07/soc-xmpp-update.php (Andreas 
+	  http://www.adiumx.com/blog/2007/07/soc-xmpp-update.php (Andreas
 	  Monitzer, Google Summer of Code for Adium)
-	* Certificate management. Libpurple will validate certificates on
+	* Certificate management. libpurple will validate certificates on
 	  SSL-encrypted protocols (William Ehlhardt, Google Summer of Code)
 	* Some adjustments were made to fix sending messages when using
 	  the MSN HTTP method. (Laszlo Pandy)
============================================================
--- libpurple/protocols/jabber/message.c	4dcef9c6278ca5f8cd62a284572b6a2949fc5d68
+++ libpurple/protocols/jabber/message.c	76a9ff5d6eb416a05c1b931cda81144e1725019d
@@ -633,24 +633,28 @@ void jabber_message_parse(JabberStream *
 					purple_debug_info("jabber", "found %d smileys\n",
 						g_list_length(smiley_refs));
 					
-					if (jm->type == JABBER_MESSAGE_GROUPCHAT) {
-						JabberID *jid = jabber_id_new(jm->from);
-						JabberChat *chat = NULL;
+					if (smiley_refs) {		
+						if (jm->type == JABBER_MESSAGE_GROUPCHAT) {
+							JabberID *jid = jabber_id_new(jm->from);
+							JabberChat *chat = NULL;
 
-						if (jid) {
-							chat = jabber_chat_find(js, jid->node, jid->domain);
-							if (chat) conv = chat->conv;
-						}
+							if (jid) {
+								chat = jabber_chat_find(js, jid->node, jid->domain);
+								if (chat) conv = chat->conv;
+							}
 
-						jabber_id_free(jid);
-					} else {
-						conv =
-							purple_find_conversation_with_account(PURPLE_CONV_TYPE_ANY,
-								who, account);
-						if (!conv) {
-							/* we need to create the conversation here */
-							conv = purple_conversation_new(PURPLE_CONV_TYPE_IM,
-								account, who);
+							jabber_id_free(jid);
+						} else if (jm->type == JABBER_MESSAGE_NORMAL ||
+						           jm->type == JABBER_MESSAGE_CHAT) {
+							conv =
+								purple_find_conversation_with_account(PURPLE_CONV_TYPE_ANY,
+									who, account);
+							if (!conv) {
+								/* we need to create the conversation here */
+								conv = 
+									purple_conversation_new(PURPLE_CONV_TYPE_IM,
+									account, who);
+							}
 						}
 					}
 
@@ -682,7 +686,7 @@ void jabber_message_parse(JabberStream *
 						    TRUE)) {
 						const JabberData *data =
 								jabber_data_find_remote_by_cid(cid);
-						/* if data is already known, we add write it immediatly */
+						/* if data is already known, we write it immediatly */
 						if (data) {
 							purple_debug_info("jabber", 
 								"data is already known\n");