pidgin: e678005b: Remove an unneeded debug log, which Mark...

evands at evands at
Sun Nov 22 18:05:27 EST 2009

Revision: e678005b4a80403eab51365dced9586b52416176
Ancestor: 077a54811da2626b11c1be8cb84c4ff3a5b0b134
Author: evands at
Date: 2009-11-22T23:05:51
Branch: im.pidgin.pidgin

Modified files:


Remove an unneeded debug log, which Mark points out might also be unsafe as it would be using %s as a formatter for a UTF-16BE string

-------------- next part --------------
--- libpurple/protocols/oscar/oscar.c	6e8f68cf556bd677d5f99a2a6ac6da782631e1d7
+++ libpurple/protocols/oscar/oscar.c	47bf0894561dc277e644876b82685ac8e663b9a0
@@ -577,7 +577,7 @@ purple_plugin_oscar_convert_to_best_enco
-	purple_debug_info("oscar", "Conversion from UTF-8 to %s failed (%s), falling back to unicode.\n",
+	purple_debug_info("oscar", "Conversion from UTF-8 to %s failed (%s). Falling back to unicode.\n",
 					  charsetstr, err->message);
 	err = NULL;
@@ -587,9 +587,6 @@ purple_plugin_oscar_convert_to_best_enco
 	*msg = g_convert(from, -1, "UTF-16BE", "UTF-8", NULL, &msglen, &err);
 	if (*msg != NULL) {
-		purple_debug_info("oscar", "Conversion from UTF-8 to UTF-16BE results in %s.\n",
-						  *msg);
 		*charset = AIM_CHARSET_UNICODE;
 		*charsubset = 0x0000;
 		*msglen_int = msglen;

More information about the Commits mailing list