pidgin.mxit: 19bd9478: If Pidgin is running in Debug mode, on W...

andrew.victor at mxit.com andrew.victor at mxit.com
Tue Nov 24 10:15:41 EST 2009


-----------------------------------------------------------------
Revision: 19bd9478a2f62f9e6ccd540f83c1ef24f308ff24
Ancestor: c2a65b2e8127f46f7c79c0bac6eaac81365319d1
Author: andrew.victor at mxit.com
Date: 2009-11-24T13:38:25
Branch: im.pidgin.pidgin.mxit
URL: http://d.pidgin.im/viewmtn/revision/info/19bd9478a2f62f9e6ccd540f83c1ef24f308ff24

Modified files:
        libpurple/protocols/mxit/splashscreen.c

ChangeLog: 

If Pidgin is running in Debug mode, on Windows, and no splash-screen is
active then a segfault may occur.


-------------- next part --------------
============================================================
--- libpurple/protocols/mxit/splashscreen.c	f07b2de175de2fa6f30dcd7c88016a8166bccb7c
+++ libpurple/protocols/mxit/splashscreen.c	e00c1ab491455573789096af7ad3ea82342ff70a
@@ -43,10 +43,10 @@ const char* splash_current(struct MXitSe
 {
 	const char* splashId = purple_account_get_string(session->acc, MXIT_CONFIG_SPLASHID, NULL);
 
-	purple_debug_info(MXIT_PLUGIN_ID, "Current splashId: '%s'\n", splashId);
-
-	if ((splashId != NULL) && (*splashId != '\0'))
+	if ((splashId != NULL) && (*splashId != '\0')) {
+		purple_debug_info(MXIT_PLUGIN_ID, "Current splashId: '%s'\n", splashId);
 		return splashId;
+	}
 	else
 		return NULL;
 }
@@ -149,7 +149,7 @@ static void splash_click_ok(PurpleConnec
 
 	/* Get current splash ID */
 	splashId = splash_current(session);
-	if (!splashId)
+	if (splashId == NULL)		/* no splash-screen */
 		return;
 
 	/* if is clickable, then send click event */


More information about the Commits mailing list