pidgin: 784f5b03: Fix an incorrect leak-fix. Thanks Elliot...

sadrul at pidgin.im sadrul at pidgin.im
Fri Oct 9 20:56:42 EDT 2009


-----------------------------------------------------------------
Revision: 784f5b030e397c41ef6ae9cb48de8ba61c871961
Ancestor: 5b55f7c6ba5c3a07e85fbc2cd0370a411c7c70db
Author: sadrul at pidgin.im
Date: 2009-10-09T17:33:16
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/784f5b030e397c41ef6ae9cb48de8ba61c871961

Modified files:
        libpurple/protocols/msn/oim.c

ChangeLog: 

Fix an incorrect leak-fix. Thanks Elliott!

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/oim.c	c32d2d1dadeb42829ec5dedc648ec23147ac4af3
+++ libpurple/protocols/msn/oim.c	f8cfdf73d17aa75cb4131dc5b1596820aec36ac8
@@ -373,6 +373,7 @@ msn_oim_send_read_cb(MsnSoapMessage *req
 								msg->oim_msg);
 							g_queue_push_head(oim->send_queue, msg);
 							msn_oim_send_msg(oim);
+							msg = NULL;
 						} else {
 							purple_debug_info("msn",
 								"Can't find lock key for OIM: %s\n",
@@ -393,6 +394,7 @@ msn_oim_send_read_cb(MsnSoapMessage *req
 						purple_debug_info("msn", "Resending OIM: %s\n", msg->oim_msg);
 						g_queue_push_head(oim->send_queue, msg);
 						msn_oim_send_msg(oim);
+						msg = NULL;
 					}
 				} else {
 					/* Report the error */
@@ -426,6 +428,9 @@ msn_oim_send_read_cb(MsnSoapMessage *req
 			}
 		}
 	}
+
+	if (msg)
+		msn_oim_free_send_req(msg);
 }
 
 void
@@ -481,7 +486,6 @@ msn_oim_send_msg(MsnOim *oim)
 
 	g_free(msg_body);
 	g_free(soap_body);
-	msn_oim_free_send_req(oim_request);
 }
 
 /****************************************


More information about the Commits mailing list