pidgin: 3d2659a1: I don't see why the Public IP entry need...

qulogic at pidgin.im qulogic at pidgin.im
Sat Sep 5 21:16:45 EDT 2009


-----------------------------------------------------------------
Revision: 3d2659a16e7e28a0f014738248c68355e5c4dbe2
Ancestor: c5a0fb57e25619218f4386d2cbb1d8499201b4cb
Author: qulogic at pidgin.im
Date: 2009-09-06T00:57:23
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/3d2659a16e7e28a0f014738248c68355e5c4dbe2

Modified files:
        pidgin/gtkprefs.c

ChangeLog: 

I don't see why the Public IP entry needs to be different and use a Table
instead of an HBox.

-------------- next part --------------
============================================================
--- pidgin/gtkprefs.c	4fd521a4d167687d1f3049061b8bb56439b59a92
+++ pidgin/gtkprefs.c	a4a47bba75b138c22fa86d9fbcd619237e6db0a8
@@ -1840,33 +1840,20 @@ network_page(void)
 	                 G_CALLBACK(auto_ip_button_clicked_cb), NULL);
 	auto_ip_button_clicked_cb(auto_ip_checkbox, NULL); /* Update label */
 
-	table = gtk_table_new(2, 2, FALSE);
-	gtk_container_set_border_width(GTK_CONTAINER(table), 0);
-	gtk_table_set_col_spacings(GTK_TABLE(table), 5);
-	gtk_table_set_row_spacings(GTK_TABLE(table), 10);
-	gtk_container_add(GTK_CONTAINER(vbox), table);
-
-	label = gtk_label_new_with_mnemonic(_("Public _IP:"));
-	gtk_misc_set_alignment(GTK_MISC(label), 0.0, 0.5);
-	gtk_table_attach(GTK_TABLE(table), label, 0, 1, 0, 1, GTK_FILL, 0, 0, 0);
-	gtk_size_group_add_widget(sg, label);
-
 	entry = gtk_entry_new();
-	gtk_label_set_mnemonic_widget(GTK_LABEL(label), entry);
-	gtk_table_attach(GTK_TABLE(table), entry, 1, 2, 0, 1, GTK_FILL, 0, 0, 0);
+	gtk_entry_set_text(GTK_ENTRY(entry), purple_network_get_public_ip());
 	g_signal_connect(G_OBJECT(entry), "changed",
 					 G_CALLBACK(network_ip_changed), NULL);
 
-	gtk_entry_set_text(GTK_ENTRY(entry), purple_network_get_public_ip());
+	hbox = pidgin_add_widget_to_vbox(GTK_BOX(vbox), _("Public _IP:"),
+			sg, entry, TRUE, NULL);
 
-	pidgin_set_accessible_label(entry, label);
-
 	if (purple_prefs_get_bool("/purple/network/auto_ip")) {
-		gtk_widget_set_sensitive(GTK_WIDGET(table), FALSE);
+		gtk_widget_set_sensitive(GTK_WIDGET(hbox), FALSE);
 	}
 
 	g_signal_connect(G_OBJECT(auto_ip_checkbox), "clicked",
-					 G_CALLBACK(pidgin_toggle_sensitive), table);
+					 G_CALLBACK(pidgin_toggle_sensitive), hbox);
 
 	g_object_unref(sg);
 


More information about the Commits mailing list