pidgin: c27911ca: Just comment out the failing tests when ...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Fri Sep 18 22:41:17 EDT 2009


-----------------------------------------------------------------
Revision: c27911caf64e39fd83a788db01e23f6b66900792
Ancestor: fc84658a6b90cc9117f2556a3ffde21ccf631970
Author: darkrain42 at pidgin.im
Date: 2009-09-19T02:36:04
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/c27911caf64e39fd83a788db01e23f6b66900792

Modified files:
        libpurple/tests/test_jabber_jutil.c

ChangeLog: 

Just comment out the failing tests when using glib; it's not likely anyone
will encounter an issue with this in the real world, and it means people
without libidn can run "make check" to find other issues.

-------------- next part --------------
============================================================
--- libpurple/tests/test_jabber_jutil.c	0d60101c5c2dae050dda907de45f1b773fcbcaf8
+++ libpurple/tests/test_jabber_jutil.c	2bfe676fff34d7405d07196f1257da01ba64c04e
@@ -142,13 +142,20 @@ START_TEST(test_jabber_id_new)
 
 	/* Cyrillic capital EF (U+0424) maps to lowercase EF (U+0444) */
 	assert_jid_parts("?", "darkrain42.org", "?@darkrain42.org");
+
+#ifdef USE_IDN
 	/*
 	 * These character (U+A664 and U+A665) are not mapped to anything in
 	 * RFC3454 B.2. This first test *fails* when not using IDN because glib's
 	 * case-folding/utf8_strdown improperly (for XMPP) lowercases the character.
+	 *
+	 * This is known, but not (very?) likely to actually cause a problem, so
+	 * this test is commented out when using glib's functions.
 	 */
 	assert_jid_parts("?", "darkrain42.org", "?@darkrain42.org");
 	assert_jid_parts("?", "darkrain42.org", "?@darkrain42.org");
+#endif
+
 	/* U+04E9 to U+04E9 */
 	assert_jid_parts("paul", "?arkrain42.org", "paul@?arkrain42.org");
 }


More information about the Commits mailing list