pidgin: ad305972: Some people seem to think these messages...

qulogic at pidgin.im qulogic at pidgin.im
Mon Sep 21 22:11:07 EDT 2009


-----------------------------------------------------------------
Revision: ad3059728a95ccf78fc978ee56938a5176224948
Ancestor: e9e9537a3c31d523f8a0c564c8e8b2c69c6a274c
Author: qulogic at pidgin.im
Date: 2009-09-12T02:25:38
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/ad3059728a95ccf78fc978ee56938a5176224948

Modified files:
        libpurple/dbus-server.c

ChangeLog: 

Some people seem to think these messages actually mean something, but not
really. And they totally ignore the 'ignore me' message too. Anyway, now
that we have the verbose debug flag, I think we can hide these under it.

-------------- next part --------------
============================================================
--- libpurple/dbus-server.c	c51bb82bc269f00e0c8ad4d31a0d5cc3a2bfc867
+++ libpurple/dbus-server.c	6c4064f3d222f1c98ffe9c2a1717bf7673227eb2
@@ -126,8 +126,10 @@ purple_dbus_pointer_to_id(gconstpointer 
 	gint id = GPOINTER_TO_INT(g_hash_table_lookup(map_node_id, node));
 	if ((id == 0) && (node != NULL))
 	{
-		purple_debug_warning("dbus",
-				"Need to register an object with the dbus subsystem. (If you are not a developer, please ignore this message.)\n");
+		if (purple_debug_is_verbose())
+			purple_debug_warning("dbus",
+				"Need to register an object with the dbus subsystem."
+				" (If you are not a developer, please ignore this message.)\n");
 		return 0;
 	}
 	return id;
@@ -795,7 +797,11 @@ purple_dbus_signal_emit_purple(const cha
 	dbus_message_iter_init_append(signal, &iter);
 
 	if (purple_dbus_message_append_purple_values(&iter, num_values, values, vargs))
-		purple_debug_warning("dbus", "The signal \"%s\" caused some dbus error. (If you are not a developer, please ignore this message.)\n", name);
+		if (purple_debug_is_verbose())
+			purple_debug_warning("dbus",
+				"The signal \"%s\" caused some dbus error."
+				" (If you are not a developer, please ignore this message.)\n",
+				name);
 
 	dbus_connection_send(purple_dbus_connection, signal, NULL);
 


More information about the Commits mailing list