pidgin: a778777f: util: Fix a crash in purple_utf8_strftim...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Sun Apr 18 17:50:09 EDT 2010


-----------------------------------------------------------------
Revision: a778777f714204be832f9a284e141896f41bbdb7
Ancestor: 5ccbe7e5a7ed60f69ca10decf2252de3f334f537
Author: florian at instantbird.org
Date: 2010-04-16T16:46:57
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/a778777f714204be832f9a284e141896f41bbdb7

Modified files:
        libpurple/util.c

ChangeLog: 

util: Fix a crash in purple_utf8_strftime.

The issue is that the GError is re-used about 10 lines later and I'm
pretty sure there are some rules about GError's always being initialized
to NULL before use.

Fixes http://crash-stats.instantbird.com/report/index/fac36bac-4bc2-41d9-b05d-fdcaa2100411

-------------- next part --------------
============================================================
--- libpurple/util.c	6b3c2336667fcf9469f246fd24c1b90afc589d2c
+++ libpurple/util.c	1d2aada9e7b88c4053deaf4faa5e400739410e90
@@ -586,6 +586,7 @@ purple_utf8_strftime(const char *format,
 	{
 		purple_debug_error("util", "Format conversion failed in purple_utf8_strftime(): %s\n", err->message);
 		g_error_free(err);
+		err = NULL;
 		locale = g_strdup(format);
 	}
 


More information about the Commits mailing list