cpw.qulogic.msnp16: 7d1398bb: MsnUserEndpoint->id isn't actually used, ...

markdoliner at pidgin.im markdoliner at pidgin.im
Thu Apr 22 16:55:52 EDT 2010


-----------------------------------------------------------------
Revision: 7d1398bb3e419750c3e8b634439ca36b44772c17
Ancestor: 420983cf8f03d72400667ceea43f8ffc3518b1c2
Author: markdoliner at pidgin.im
Date: 2010-04-22T20:51:24
Branch: im.pidgin.cpw.qulogic.msnp16
URL: http://d.pidgin.im/viewmtn/revision/info/7d1398bb3e419750c3e8b634439ca36b44772c17

Modified files:
        libpurple/protocols/msn/user.c
        libpurple/protocols/msn/user.h

ChangeLog: 

MsnUserEndpoint->id isn't actually used, so let's not store it in the
struct.  It's used as the key in the endpoints hashtable, so hopefully
we can get away with keeping only one copy of it

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/user.c	59837943f9b41bab387dc5958382c5dc892f2374
+++ libpurple/protocols/msn/user.c	bc9cd46afb769a54e363512b81ae74948a1cba2b
@@ -230,7 +230,6 @@ free_user_endpoint(MsnUserEndpoint *data
 static void
 free_user_endpoint(MsnUserEndpoint *data)
 {
-	g_free(data->id);
 	g_free(data->name);
 	g_free(data);
 }
@@ -255,7 +254,6 @@ msn_user_set_endpoint_data(MsnUser *user
 	new = g_hash_table_lookup(user->endpoints, endpoint);
 	if (!new) {
 		new = g_new0(MsnUserEndpoint, 1);
-		new->id = g_strdup(endpoint);
 		g_hash_table_insert(user->endpoints, g_strdup(endpoint), new);
 	}
 
============================================================
--- libpurple/protocols/msn/user.h	ba69faa471ea1fdf8e4db757d2ac7dd8c728200f
+++ libpurple/protocols/msn/user.h	b333731cd8fed57a3163a965a140e570deb9efa5
@@ -122,7 +122,6 @@ typedef struct MsnUserEndpoint {
  * A specific user endpoint.
  */
 typedef struct MsnUserEndpoint {
-	char *id;				/**< The client's endpoint ID          */
 	char *name;				/**< The client's endpoint's name      */
 	int type;				/**< The client's endpoint type        */
 	guint clientid;         /**< The client's ID                   */


More information about the Commits mailing list