pidgin: 8cd7ebe0: gadu-gadu: Fix a crash due to uninitiali...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Wed Apr 28 18:15:40 EDT 2010


-----------------------------------------------------------------
Revision: 8cd7ebe0ee16aad48725ab266cbf8a76b5f6fe7b
Ancestor: 33247eb604d4bf72c0c2fdf0f89348db8cc960c6
Author: darkrain42 at pidgin.im
Date: 2010-04-28T22:13:51
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/8cd7ebe0ee16aad48725ab266cbf8a76b5f6fe7b

Modified files:
        libpurple/protocols/gg/gg.c

ChangeLog: 

gadu-gadu: Fix a crash due to uninitialized data.  Closes #11746.

This is a different fix, based on feedback on the libgadu mailing list.
"It's a feature, not a bug. You're supposed to iterate through the array
until there's uin == 0."

-------------- next part --------------
============================================================
--- libpurple/protocols/gg/gg.c	df0806379c3b3d0068b334f510d18c44facc5696
+++ libpurple/protocols/gg/gg.c	736287c1e736efe0c596a18015a7e8c04fb9c2f7
@@ -1601,12 +1601,6 @@ static void ggp_callback_recv(gpointer _
 			}
 			break;
 		case GG_EVENT_NOTIFY60:
-			purple_debug_info("gg",
-				"notify60_pre: (%d) status=%d; version=%d; descr=%s\n",
-				ev->event.notify60->uin, GG_S(ev->event.notify60->status),
-				ev->event.notify60->version,
-				ev->event.notify60->descr ? ev->event.notify60->descr : "(null)");
-
 			for (i = 0; ev->event.notify60[i].uin; i++) {
 				purple_debug_info("gg",
 					"notify60: (%d) status=%d; version=%d; descr=%s\n",


More information about the Commits mailing list