pidgin: a64b15de: There's no reason to cache this value, r...

markdoliner at pidgin.im markdoliner at pidgin.im
Fri Aug 6 13:25:47 EDT 2010


----------------------------------------------------------------------
Revision: a64b15dea99395714cd38d5375d11e8e5c7ba3ef
Parent:   a761563b9d1cddc4d3fee3791527a2fc5b2739d4
Author:   markdoliner at pidgin.im
Date:     08/06/10 13:24:10
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/a64b15dea99395714cd38d5375d11e8e5c7ba3ef

Changelog: 

There's no reason to cache this value, right?

Changes against parent a761563b9d1cddc4d3fee3791527a2fc5b2739d4

  patched  libpurple/protocols/msn/soap.c

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/soap.c	d24abaab0e1436336ad8cad30dd04132533690f1
+++ libpurple/protocols/msn/soap.c	710f02cb4dfe1adc161c008e3d846b16d011de31
@@ -68,7 +68,6 @@ typedef struct _MsnSoapConnection {
 
 	GQueue *queue;
 	MsnSoapRequest *current_request;
-	gboolean unsafe_debug;
 } MsnSoapConnection;
 
 static gboolean msn_soap_connection_run(gpointer data);
@@ -80,7 +79,6 @@ msn_soap_connection_new(MsnSession *sess
 	conn->session = session;
 	conn->host = g_strdup(host);
 	conn->queue = g_queue_new();
-	conn->unsafe_debug = purple_debug_is_unsafe();
 	return conn;
 }
 
@@ -509,7 +507,7 @@ msn_soap_read_cb(gpointer data, gint fd,
 		purple_debug_info("soap", "read: %s\n", g_strerror(perrno));
 
 	if (conn->current_request && conn->current_request->secure &&
-		!conn->unsafe_debug)
+		!purple_debug_is_unsafe())
 		purple_debug_misc("soap", "Received secure request.\n");
 	else if (count != 0)
 		purple_debug_misc("soap", "current %s\n", conn->buf->str + cursor);
@@ -659,7 +657,7 @@ msn_soap_connection_run(gpointer data)
 			g_string_append(conn->buf, "\r\n");
 			g_string_append(conn->buf, body);
 
-			if (req->secure && !conn->unsafe_debug)
+			if (req->secure && !purple_debug_is_unsafe())
 				purple_debug_misc("soap", "Sending secure request.\n");
 			else
 				purple_debug_misc("soap", "%s\n", conn->buf->str);


More information about the Commits mailing list