pidgin: 36829693: Using if (x) g_free(x) is unnecessary.

qulogic at pidgin.im qulogic at pidgin.im
Thu Aug 26 00:40:46 EDT 2010


----------------------------------------------------------------------
Revision: 368296936e15c70f7c6d75a25cf4c21bf1f752c0
Parent:   dcc92bf5bf2f627deda9931546a5f10f2e02247d
Author:   qulogic at pidgin.im
Date:     08/26/10 00:28:20
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/368296936e15c70f7c6d75a25cf4c21bf1f752c0

Changelog: 

Using if (x) g_free(x) is unnecessary.

Changes against parent dcc92bf5bf2f627deda9931546a5f10f2e02247d

  patched  pidgin/plugins/gevolution/add_buddy_dialog.c
  patched  pidgin/plugins/gevolution/new_person_dialog.c

-------------- next part --------------
============================================================
--- pidgin/plugins/gevolution/add_buddy_dialog.c	8342068a07a9a2d60f7422d22b72da99a7d691f2
+++ pidgin/plugins/gevolution/add_buddy_dialog.c	cd855a4aa8094ec55c3480bcc0b7893f1593beff
@@ -54,8 +54,7 @@ delete_win_cb(GtkWidget *w, GdkEvent *ev
 
 	gevo_addrbooks_model_unref(dialog->addrbooks);
 
-	if (dialog->username != NULL)
-		g_free(dialog->username);
+	g_free(dialog->username);
 
 	g_free(dialog);
 
============================================================
--- pidgin/plugins/gevolution/new_person_dialog.c	a8f26ad12cb80e3adeedfedd43b31b7d8135383b
+++ pidgin/plugins/gevolution/new_person_dialog.c	7eaf3adef3dd53cf3aae2156dfa673c26851cdf3
@@ -204,8 +204,7 @@ add_cb(GtkWidget *w, GevoNewPersonDialog
 	if (name != NULL)
 		e_contact_name_free(name);
 
-	if (full_name != NULL)
-		g_free(full_name);
+	g_free(full_name);
 
 	delete_win_cb(NULL, NULL, dialog);
 }


More information about the Commits mailing list