pidgin: 55719894: jabber: Log a warning (with the shortcut...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Wed Feb 3 16:45:37 EST 2010


-----------------------------------------------------------------
Revision: 557198948608028bc4f826a546a3948c4899bdf0
Ancestor: 458aff4862f0fdf41fb40bec1a64146b802b37ce
Author: darkrain42 at pidgin.im
Date: 2010-02-03T21:40:39
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/557198948608028bc4f826a546a3948c4899bdf0

Modified files:
        ChangeLog libpurple/protocols/jabber/message.c

ChangeLog: 

jabber: Log a warning (with the shortcut) when refusing to send a smiley.

-------------- next part --------------
============================================================
--- ChangeLog	931173117e36f6cf6a7bbf3a74787c2631817e53
+++ ChangeLog	7015ba79e284747d2c8ed517dcec179fb00187d0
@@ -38,8 +38,8 @@ version 2.6.6 (??/??/20??):
 	* Don't do an SRV lookup for a STUN server associated with the account
 	  if one is already set globally in prefs.
 	* Don't send custom smileys larger than the recommended maximum object size
-	  specified in the BoB XEP. Will prevent getting disconnected because of
-	  sending to large stanzas.
+	  specified in the BoB XEP.   This prevents a client from being
+	  disconnected by servers that dislike overly-large stanzas.
 
 	Yahoo:
 	* Don't send <span> and </span> tags.  (Fartash Faghri)
============================================================
--- libpurple/protocols/jabber/message.c	c309a5a8b0bc3452cf3bc9d014f0575e060b223e
+++ libpurple/protocols/jabber/message.c	c70839219e5cdc78427ac3d3bb10acebd9853841
@@ -1013,6 +1013,10 @@ jabber_message_smileyfy_xhtml(JabberMess
 					valid_smileys = g_list_append(valid_smileys, smiley);
 				} else {
 					has_too_large_smiley = TRUE;
+					purple_debug_warning("jabber", "Refusing to send smiley %s "
+							"(too large, max is %d)\n",
+							purple_smiley_get_shortcut(smiley),
+							JABBER_DATA_MAX_SIZE);
 				}				
 			}
 


More information about the Commits mailing list